Skip to content

optimize: use retry logic to end global trx #7283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
funky-eyes merged 5 commits into from
Apr 17, 2025
Merged

optimize: use retry logic to end global trx #7283

funky-eyes merged 5 commits into from
Apr 17, 2025

Conversation

@xjlgod
Copy link
Contributor

@xjlgod xjlgod commented Apr 12, 2025

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Use retry logic to end global trx. Previously, there were some interfaces that did not have the end logic or were implemented in some other way

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@xjlgod xjlgod requested a review from funky-eyes April 12, 2025 12:42
funky-eyes
funky-eyes approved these changes Apr 16, 2025
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.4.0 milestone Apr 16, 2025
funky-eyes
funky-eyes reviewed Apr 16, 2025
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error: /home/runner/work/incubator-seata/incubator-seata/server/src/main/java/org/apache/seata/server/console/impl/AbstractGlobalService.java:23:8: Unused import - org.apache.seata.server.coordinator.DefaultCoordinator. [UnusedImports]
Error: /home/runner/work/incubator-seata/incubator-seata/server/src/main/java/org/apache/seata/server/console/impl/AbstractGlobalService.java:26:8: Unused import - org.apache.seata.server.session.SessionHolder. [UnusedImports]

@codecov
Copy link

codecov bot commented Apr 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 54.20%. Comparing base (b1f0c04) to head (b00c0b4).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ata/server/console/impl/AbstractGlobalService.java 0.00% 4 Missing ⚠️
...che/seata/server/console/impl/AbstractService.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x    #7283      +/-   ##
============================================
- Coverage     54.21%   54.20%   -0.01%     
+ Complexity     7267     7266       -1     
============================================
  Files          1178     1178              
  Lines         41969    41961       -8     
  Branches       4926     4923       -3     
============================================
- Hits          22754    22746       -8     
  Misses        17063    17063              
  Partials       2152     2152
Files with missing lines Coverage Δ
...che/seata/server/console/impl/AbstractService.java 55.55% <0.00%> (ø)
...ata/server/console/impl/AbstractGlobalService.java 30.76% <0.00%> (+2.86%) ⬆️

... and 7 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xjlgod
Copy link
Contributor Author

xjlgod commented Apr 16, 2025

Error: /home/runner/work/incubator-seata/incubator-seata/server/src/main/java/org/apache/seata/server/console/impl/AbstractGlobalService.java:23:8: Unused import - org.apache.seata.server.coordinator.DefaultCoordinator. [UnusedImports] Error: /home/runner/work/incubator-seata/incubator-seata/server/src/main/java/org/apache/seata/server/console/impl/AbstractGlobalService.java:26:8: Unused import - org.apache.seata.server.session.SessionHolder. [UnusedImports]

fixed it

@funky-eyes funky-eyes merged commit 13d2db4 into apache:2.x Apr 17, 2025
8 of 9 checks passed
xingfudeshi pushed a commit that referenced this pull request Apr 17, 2025
@jsbxyyx
optimize: use retry logic to end global trx (#7283) (#7299)
8532beb
jsbxyyx added a commit to jsbxyyx/incubator-seata that referenced this pull request May 26, 2025
@jsbxyyx
optimize: use retry logic to end global trx (apache#7283) (apache#7299)
599c668
slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
@xjlgod
optimize: use retry logic to end global trx (apache#7283)
356a072
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
@xjlgod
optimize: use retry logic to end global trx (apache#7283)
045883f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@funky-eyes funky-eyes funky-eyes approved these changes

Assignees

No one assigned

Labels

module/console module/server server module type: optimize

Projects

None yet

Milestone

2.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@xjlgod @funky-eyes