Skip to content

Conversation

@YoWuwuuuw
Copy link
Contributor

@YoWuwuuuw YoWuwuuuw commented Apr 3, 2025

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

1)Optimized CI Trigger Conditions:
●Skip CI for .md file-only changes: CI process will not be triggered when the PR only contains modifications to .md files (like: #7226) , reducing unnecessary resource consumption.
●PR Status Filtering: Avoid closed PRs (like: #7263) from occupying CI activities and prevent the Codecov bot from commenting on closed PRs.

2)Maven Repository Caching:
●Added caching for the Maven repository to accelerate build preparation and speed up CI testing (estimated improvement of 30-60 seconds). Cache status and usage can be viewed at https://github.com/apache/incubator-seata/actions/caches.
Reference

3)Retry Mechanism:
●Introduced a retry mechanism(1 time) to avoid CI failures caused by occasional issues. For example, in https://github.com/apache/incubator-seata/actions/runs/14049309257/job/39336574577?pr=7225 and https://github.com/apache/incubator-seata/actions/runs/14026429452/job/39265823304, CI occasionally fails due to sporadic problems (which should not happen), requiring manual triggering of CI.
●Optimization Enhancement: Manually triggered CI rebuilds tests for all versions, while automatic retries only retry tests for the failed versions, improving efficiency.
Reference

The corresponding ci measurement can be seen in my fork repo: https://github.com/YoWuwuuuw/incubator-seata

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.72%. Comparing base (ac99e5b) to head (8cc7da6).
Report is 3 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #7270      +/-   ##
============================================
- Coverage     55.75%   55.72%   -0.03%     
+ Complexity     7469     7463       -6     
============================================
  Files          1178     1178              
  Lines         41962    41962              
  Branches       4923     4923              
============================================
- Hits          23396    23385      -11     
- Misses        16328    16342      +14     
+ Partials       2238     2235       -3     

see 7 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@slievrly slievrly added this to the 2.4.0 milestone Apr 4, 2025
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi
Copy link
Member

Well done!

@slievrly slievrly removed this from the 2.4.0 milestone Apr 16, 2025
@YoWuwuuuw
Copy link
Contributor Author

@slievrly @funky-eyes PTAL

@slievrly slievrly added this to the 2.5.0 milestone May 14, 2025
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 3b40167 into apache:2.x May 14, 2025
9 checks passed
slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants