Skip to content

Conversation

@wjwang00
Copy link
Contributor

…ge(#6503)

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Add more unit tests for Discovery-Eureka to improve test coverage

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.21%. Comparing base (f083840) to head (0e68962).
Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #7255      +/-   ##
============================================
+ Coverage     54.17%   54.21%   +0.03%     
- Complexity     7257     7268      +11     
============================================
  Files          1178     1178              
  Lines         41952    41952              
  Branches       4923     4923              
============================================
+ Hits          22729    22745      +16     
+ Misses        17069    17058      -11     
+ Partials       2154     2149       -5     

see 7 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@slievrly slievrly changed the title test: Add more unit tests for Discovery-Eureka to improve test covera… test: add unit tests for Eureka module Mar 31, 2025
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 6083fa1 into apache:2.x Mar 31, 2025
9 checks passed
@slievrly slievrly added this to the 2.4.0 milestone Mar 31, 2025
slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants