-
Notifications
You must be signed in to change notification settings - Fork 8.9k
optimize: upgrade tomcat-embed-core to 9.0.99 #7241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
funky-eyes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please register your PR in those two files :
https://github.com/apache/incubator-seata/blob/2.x/changes/en-us/2.x.md
|
ok, I have registered the PR changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7241 +/- ##
=========================================
Coverage 53.98% 53.99%
- Complexity 7203 7204 +1
=========================================
Files 1173 1173
Lines 41792 41796 +4
Branches 4905 4906 +1
=========================================
+ Hits 22561 22567 +6
+ Misses 17099 17097 -2
Partials 2132 2132 🚀 New features to boost your workflow:
|
slievrly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
upgrade tomcat-embed-core to 9.0.99 to fix CVE-2025-24813
Ⅱ. Does this pull request fix one issue?
fiexs #7240
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews