Skip to content

Conversation

@hokkine
Copy link
Contributor

@hokkine hokkine commented Mar 18, 2025

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

#7212

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@hokkine hokkine changed the title feat: add mock test for seata-discovery-etcd3 test: add mock test for seata-discovery-etcd3 Mar 18, 2025
@codecov
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.19%. Comparing base (13509de) to head (fbaf53e).
Report is 2 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #7233      +/-   ##
============================================
+ Coverage     53.99%   54.19%   +0.20%     
- Complexity     7205     7226      +21     
============================================
  Files          1173     1173              
  Lines         41796    41796              
  Branches       4906     4906              
============================================
+ Hits          22566    22653      +87     
+ Misses        17099    17004      -95     
- Partials       2131     2139       +8     

see 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

import java.net.InetSocketAddress;
import java.util.Arrays;
import java.util.List;
import java.util.concurrent.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don’t import *.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I fixed this

@xingfudeshi xingfudeshi added the first-time contributor first-time contributor label Mar 21, 2025
@slievrly slievrly added this to the 2.4.0 milestone Mar 24, 2025
@slievrly
Copy link
Member

@hokkine thanks for your contribution.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 517f58d into apache:2.x Mar 24, 2025
9 checks passed
slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first-time contributor first-time contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants