-
Notifications
You must be signed in to change notification settings - Fork 8.9k
test: add mock test for seata-discovery-etcd3 #7233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7233 +/- ##
============================================
+ Coverage 53.99% 54.19% +0.20%
- Complexity 7205 7226 +21
============================================
Files 1173 1173
Lines 41796 41796
Branches 4906 4906
============================================
+ Hits 22566 22653 +87
+ Misses 17099 17004 -95
- Partials 2131 2139 +8 🚀 New features to boost your workflow:
|
| import java.net.InetSocketAddress; | ||
| import java.util.Arrays; | ||
| import java.util.List; | ||
| import java.util.concurrent.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don’t import *.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I fixed this
|
@hokkine thanks for your contribution. |
slievrly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
#7212
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews