Skip to content

Conversation

@mehedikhan72
Copy link
Contributor

I just started messing around with Seata and I noticed that the CONTRIBUTING.md was not written in standard English. There were a lot of improvements to be made.

I did my best.

@xingfudeshi xingfudeshi added the first-time contributor first-time contributor label Mar 17, 2025
@xingfudeshi
Copy link
Member

@mehedikhan72 Well done. We need more native English speakers like you to assist in our improvement.

@xingfudeshi
Copy link
Member

Please include your GitHub ID in the pull request as well.
image

@codecov
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.61%. Comparing base (e0dc0c3) to head (fca0e4b).
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #7226      +/-   ##
============================================
- Coverage     53.62%   53.61%   -0.01%     
+ Complexity     7130     7129       -1     
============================================
  Files          1171     1171              
  Lines         41619    41619              
  Branches       4877     4877              
============================================
- Hits          22319    22316       -3     
- Misses        17191    17194       +3     
  Partials       2109     2109              

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mehedikhan72
Copy link
Contributor Author

Hi @xingfudeshi , I added the github ID.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit d300796 into apache:2.x Mar 17, 2025
8 checks passed
@slievrly slievrly added this to the 2.4.0 milestone Mar 17, 2025
slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first-time contributor first-time contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants