feature: support kingbase xa mode #7213
Conversation
funky-eyes
added
type: feature
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Kingbase XA mode to the project. Key changes include adding a new test case for Kingbase XA connections, updating XAUtils.java to handle the Kingbase database type, and updating the changelog files in both en-us and zh-cn documentation.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rm-datasource/src/test/java/org/apache/seata/rm/datasource/xa/DataSourceProxyXATest.java | Added test to verify proper handling of Kingbase XA connection |
| rm-datasource/src/main/java/org/apache/seata/rm/datasource/util/XAUtils.java | Implemented Kingbase case with reflection to create Kingbase XA connection |
| changes/en-us/2.x.md | Updated changelog with Kingbase XA mode support |
| changes/zh-cn/2.x.md | Updated changelog with Kingbase XA mode support |
Comments suppressed due to low confidence (1)
rm-datasource/src/main/java/org/apache/seata/rm/datasource/util/XAUtils.java:115
- Ensure that 'com.kingbase8.core.BaseConnection' is the correct parameter type expected by Kingbase XA connections. If the actual connection type is 'com.kingbase8.jdbc.KbConnection' or a subclass thereof, this mismatch could lead to runtime reflection errors.
Class<?> kingbaseConnectionClass = Class.forName("com.kingbase8.core.BaseConnection");
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7213 +/- ##
============================================
+ Coverage 53.59% 53.60% +0.01%
- Complexity 7119 7123 +4
============================================
Files 1171 1171
Lines 41602 41607 +5
Branches 4875 4875
============================================
+ Hits 22295 22304 +9
+ Misses 17197 17195 -2
+ Partials 2110 2108 -2
🚀 New features to boost your workflow:
|
The driver scope of Kingbase is test, which is not included in the released binary, so I think it should comply with ASF regulations. |
2 participants
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #7192
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews