Skip to content

feature: raft implements domain name resolution and selects peerId #7181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
funky-eyes merged 4 commits into from
Feb 25, 2025
Merged

feature: raft implements domain name resolution and selects peerId #7181

funky-eyes merged 4 commits into from
Feb 25, 2025

Conversation

@PeppaO
Copy link
Contributor

@PeppaO PeppaO commented Feb 24, 2025 •
edited
Loading

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

raft不设置SEATA_IP，raft实现域名解析并选择peerId

Ⅱ. Does this pull request fix one issue?

#7082

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@PeppaO PeppaO changed the title bugfix: In raft mode, the service domain name is used as xid. The xid is too long and an error occurs in XA mode xid is the svc domain name, causing xa to report an error Feb 24, 2025
funky-eyes
funky-eyes reviewed Feb 24, 2025
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is not a bugfix PR because, according to the changes you listed, the first point is a feature and the second point is an optimization.

@PeppaO PeppaO changed the title xid is the svc domain name, causing xa to report an error feature: xid is the svc domain name, causing xa to report an error Feb 24, 2025
@PeppaO PeppaO changed the title feature: xid is the svc domain name, causing xa to report an error feature: raft does not set SEATA_IP, raft implements domain name resolution and selects peerId Feb 24, 2025
@PeppaO PeppaO changed the title feature: raft does not set SEATA_IP, raft implements domain name resolution and selects peerId feature: raft implements domain name resolution and selects peerId Feb 24, 2025
@codecov
Copy link

codecov bot commented Feb 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 23.80952% with 16 lines in your changes missing coverage. Please review.

Project coverage is 52.06%. Comparing base (679a2e0) to head (11aa15f).
Report is 3 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ain/java/org/apache/seata/common/util/NetUtil.java 0.00% 14 Missing ⚠️
...e/seata/server/cluster/raft/RaftServerManager.java 71.42% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #7181      +/-   ##
============================================
- Coverage     52.20%   52.06%   -0.15%     
- Complexity     6817     6855      +38     
============================================
  Files          1154     1169      +15     
  Lines         41116    41461     +345     
  Branches       4820     4850      +30     
============================================
+ Hits          21464    21585     +121     
- Misses        17611    17822     +211     
- Partials       2041     2054      +13
Files with missing lines Coverage Δ
...e/seata/server/cluster/raft/RaftServerManager.java 80.00% <71.42%> (-4.16%) ⬇️
...ain/java/org/apache/seata/common/util/NetUtil.java 47.97% <0.00%> (-5.02%) ⬇️

... and 11 files with indirect coverage changes

funky-eyes
funky-eyes approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.4.0 milestone Feb 24, 2025
@funky-eyes funky-eyes merged commit 5c353cf into apache:2.x Feb 25, 2025
8 checks passed
slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
@PeppaO
feature: raft implements domain name resolution and selects peerId (a…
4e605ac 
…pache#7181)
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
@PeppaO
feature: raft implements domain name resolution and selects peerId (a…
56c140b 
…pache#7181)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@funky-eyes funky-eyes funky-eyes approved these changes

Assignees

No one assigned

Labels

module/server server module store: raft

Projects

None yet

Milestone

2.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@PeppaO @funky-eyes