Skip to content

Conversation

@xingfudeshi
Copy link
Member

@xingfudeshi xingfudeshi commented Feb 10, 2025

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #7148

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@xingfudeshi xingfudeshi changed the title optimize:Fix abnormal character display issues in ./distribution/NOTICE.md (WIP)optimize:Fix abnormal character display issues in ./distribution/NOTICE.md Feb 10, 2025
@codecov
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.78%. Comparing base (d54c1c4) to head (14722db).
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #7149      +/-   ##
============================================
+ Coverage     51.77%   51.78%   +0.01%     
+ Complexity     6754     6751       -3     
============================================
  Files          1151     1151              
  Lines         40970    40970              
  Branches       4803     4803              
============================================
+ Hits          21213    21218       +5     
+ Misses        17762    17759       -3     
+ Partials       1995     1993       -2     

see 5 files with indirect coverage changes

@xingfudeshi xingfudeshi changed the title (WIP)optimize:Fix abnormal character display issues in ./distribution/NOTICE.md optimize:Fix abnormal character display issues in ./distribution/NOTICE.md Feb 10, 2025
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit 795f274 into apache:2.x Feb 10, 2025
8 checks passed
@slievrly slievrly added this to the 2.4.0 milestone Feb 11, 2025
slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The ./distribution/NOTICE.md file has abnormal character display issues

3 participants