Skip to content

Conversation

@slievrly
Copy link
Member

@slievrly slievrly commented Feb 8, 2025

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

remove unused dependencies

Ⅱ. Does this pull request fix one issue?

#7138

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.4.0 milestone Feb 8, 2025
@funky-eyes funky-eyes added type: optimize dependencies Pull requests that update a dependency file labels Feb 8, 2025
@codecov
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.78%. Comparing base (903c6a3) to head (90d125d).
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x    #7141   +/-   ##
=========================================
  Coverage     51.78%   51.78%           
+ Complexity     6757     6755    -2     
=========================================
  Files          1151     1151           
  Lines         40970    40970           
  Branches       4803     4803           
=========================================
  Hits          21218    21218           
+ Misses        17759    17756    -3     
- Partials       1993     1996    +3     

see 5 files with indirect coverage changes

@funky-eyes funky-eyes merged commit b11cc1d into apache:2.x Feb 8, 2025
8 checks passed
slievrly added a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file type: optimize

Development

Successfully merging this pull request may close these issues.

2 participants