Skip to content

Conversation

@YongGoose
Copy link
Member

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #7136

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@YongGoose
Copy link
Member Author

I'll write the changes after this PR has been merged.

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@funky-eyes funky-eyes added this to the 2.4.0 milestone Feb 7, 2025
@codecov
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.79%. Comparing base (0a66e5b) to head (88376d6).
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x    #7139   +/-   ##
=========================================
  Coverage     51.78%   51.79%           
- Complexity     6752     6756    +4     
=========================================
  Files          1151     1151           
  Lines         40970    40970           
  Branches       4803     4803           
=========================================
+ Hits          21217    21219    +2     
+ Misses        17757    17756    -1     
+ Partials       1996     1995    -1     

see 2 files with indirect coverage changes

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Pls add change in 2.x.md

@YongGoose
Copy link
Member Author

LGTM, Pls add change in 2.x.md

Done in 88376d6 !

PTAL :)

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added type: optimize dependencies Pull requests that update a dependency file labels Feb 8, 2025
@funky-eyes funky-eyes merged commit bf3fe24 into apache:2.x Feb 8, 2025
8 checks passed
slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file type: optimize

Development

Successfully merging this pull request may close these issues.

xstream 1.4.20 has a CVE security issue

3 participants