Skip to content

optimize:Expose some keepalive-related configuration for Druid, Hikari, and DBCP #7130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xingfudeshi merged 15 commits into from
Feb 12, 2025
Merged

optimize:Expose some keepalive-related configuration for Druid, Hikari, and DBCP #7130

xingfudeshi merged 15 commits into from
Feb 12, 2025

Conversation

@xingfudeshi
Copy link
Member

@xingfudeshi xingfudeshi commented Jan 23, 2025 •
edited
Loading

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Expose some keepalive-related configuration for Druid, Hikari, and DBCP to allow users to customize database connection pool settings.

Ⅱ. Does this pull request fix one issue?

Fixes #6600

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 54.54545% with 40 lines in your changes missing coverage. Please review.

Project coverage is 51.78%. Comparing base (2055817) to head (8b3b0f0).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
...igure/properties/server/store/DruidProperties.java 50.00% 11 Missing ⚠️
...figure/properties/server/store/DbcpProperties.java 50.00% 9 Missing ⚠️
...gure/properties/server/store/HikariProperties.java 50.00% 9 Missing ⚠️
...e/seata/server/store/HikariDataSourceProvider.java 55.55% 0 Missing and 4 partials ⚠️
...configure/SeataServerEnvironmentPostProcessor.java 0.00% 3 Missing ⚠️
...che/seata/server/store/DbcpDataSourceProvider.java 75.00% 0 Missing and 2 partials ⚠️
...he/seata/server/store/DruidDataSourceProvider.java 80.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #7130      +/-   ##
============================================
+ Coverage     51.76%   51.78%   +0.02%     
- Complexity     6754     6769      +15     
============================================
  Files          1151     1154       +3     
  Lines         40975    41057      +82     
  Branches       4803     4811       +8     
============================================
+ Hits          21212    21263      +51     
- Misses        17767    17790      +23     
- Partials       1996     2004       +8
Files with missing lines Coverage Δ
...ava/org/apache/seata/common/ConfigurationKeys.java 0.00% <ø> (ø)
...in/java/org/apache/seata/common/DefaultValues.java 0.00% <ø> (ø)
...ta/spring/boot/autoconfigure/StarterConstants.java 100.00% <ø> (ø)
...che/seata/server/store/DbcpDataSourceProvider.java 92.00% <75.00%> (-8.00%) ⬇️
...he/seata/server/store/DruidDataSourceProvider.java 92.85% <80.00%> (-7.15%) ⬇️
...configure/SeataServerEnvironmentPostProcessor.java 0.00% <0.00%> (ø)
...e/seata/server/store/HikariDataSourceProvider.java 87.87% <55.55%> (-12.13%) ⬇️
...figure/properties/server/store/DbcpProperties.java 50.00% <50.00%> (ø)
...gure/properties/server/store/HikariProperties.java 50.00% <50.00%> (ø)
...igure/properties/server/store/DruidProperties.java 50.00% <50.00%> (ø)

... and 6 files with indirect coverage changes

slievrly
slievrly reviewed Feb 2, 2025
View reviewed changes
funky-eyes
funky-eyes approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.4.0 milestone Feb 12, 2025
@xingfudeshi xingfudeshi merged commit 6b25b21 into apache:2.x Feb 12, 2025
8 checks passed
slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
@xingfudeshi
optimize:Expose some keepalive-related configuration for Druid, Hikar…
6b6d7b0 
…i, and DBCP (apache#7130)
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
@xingfudeshi
optimize:Expose some keepalive-related configuration for Druid, Hikar…
585010b 
…i, and DBCP (apache#7130)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slievrly slievrly slievrly left review comments

@funky-eyes funky-eyes funky-eyes approved these changes

Assignees

No one assigned

Labels

module/server server module type: optimize

Projects

None yet

Milestone

2.4.0

Development

Successfully merging this pull request may close these issues.

druid连接池配置参数放开test-on-borrow

3 participants

@xingfudeshi @slievrly @funky-eyes