Skip to content

bugfix: prefix: [seata.server.raft.ssl] should not be null #7116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
funky-eyes merged 9 commits into from
Jan 16, 2025
Merged

bugfix: prefix: [seata.server.raft.ssl] should not be null #7116

funky-eyes merged 9 commits into from
Jan 16, 2025

Conversation

@funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Jan 16, 2025

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #7115

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added this to the 2.4.0 milestone Jan 16, 2025
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/server server module module/seata-spring-autoconfigure-server labels Jan 16, 2025
@funky-eyes funky-eyes requested a review from slievrly January 16, 2025 03:09
xingfudeshi
xingfudeshi approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 22.72727% with 34 lines in your changes missing coverage. Please review.

Project coverage is 53.16%. Comparing base (6799dc9) to head (02d6f63).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ies/server/raft/ServerRaftSSLClientProperties.java 25.00% 9 Missing ⚠️
...roperties/server/raft/ServerRaftSSLProperties.java 30.76% 9 Missing ⚠️
...ies/server/raft/ServerRaftSSLServerProperties.java 25.00% 9 Missing ⚠️
...configure/SeataServerEnvironmentPostProcessor.java 0.00% 3 Missing ⚠️
...g/apache/seata/server/cluster/raft/RaftServer.java 0.00% 3 Missing ⚠️
...e/seata/server/instance/ServerInstanceFactory.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #7116      +/-   ##
============================================
- Coverage     53.19%   53.16%   -0.04%     
- Complexity     6799     6806       +7     
============================================
  Files          1133     1136       +3     
  Lines         40302    40341      +39     
  Branches       4721     4723       +2     
============================================
+ Hits          21440    21448       +8     
- Misses        16820    16852      +32     
+ Partials       2042     2041       -1
Files with missing lines Coverage Δ
...ava/org/apache/seata/common/ConfigurationKeys.java 0.00% <ø> (ø)
...ta/spring/boot/autoconfigure/StarterConstants.java 100.00% <ø> (ø)
...e/properties/server/raft/ServerRaftProperties.java 100.00% <ø> (ø)
...e/seata/server/instance/ServerInstanceFactory.java 58.33% <0.00%> (-2.78%) ⬇️
...configure/SeataServerEnvironmentPostProcessor.java 0.00% <0.00%> (ø)
...g/apache/seata/server/cluster/raft/RaftServer.java 52.45% <0.00%> (ø)
...ies/server/raft/ServerRaftSSLClientProperties.java 25.00% <25.00%> (ø)
...roperties/server/raft/ServerRaftSSLProperties.java 30.76% <30.76%> (ø)
...ies/server/raft/ServerRaftSSLServerProperties.java 25.00% <25.00%> (ø)

... and 5 files with indirect coverage changes

@funky-eyes funky-eyes merged commit 4632770 into apache:2.x Jan 16, 2025
8 checks passed
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
@funky-eyes
bugfix: prefix: [seata.server.raft.ssl] should not be null (apache#7116)
79a2b02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xingfudeshi xingfudeshi xingfudeshi approved these changes

@slievrly slievrly Awaiting requested review from slievrly

@wt-better wt-better Awaiting requested review from wt-better

Assignees

No one assigned

Labels

module/seata-spring-autoconfigure-server module/server server module type: bug Category issues or prs related to bug.

Projects

None yet

Milestone

2.4.0

Development

Successfully merging this pull request may close these issues.

PropertyClass for prefix: [seata.server.raft.ssl] should not be null.

3 participants

@funky-eyes @xingfudeshi @wt-better