Skip to content

Conversation

@psxjoy
Copy link
Member

@psxjoy psxjoy commented Jan 8, 2025

  • I have registered the PR changes.
  • I have optimized the code using seata-codestyle.xml.
  • I have checked all codes using seata-checkstyle.xml.

Ⅰ. Describe what this PR did

Add unit test cases to complete the unit testing objectives for the seata-common module.
增加单元测试用例,完成commons模块的单元测试目标

Instructions Cov. Branches Cov. Missed Cxty Missed Lines Missed Missed
Before 73% 66% 431 1,183 673 2,438 182 16
After 81% 73% 319 1,138 451 2,438 102 9

Ⅱ. Does this pull request fix one issue?

fixes #187

Ⅲ. Why don't you add test cases (unit test/integration test)?

Not applicable.
不适用

Ⅳ. Describe how to verify it

Run mvn clean test

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.18%. Comparing base (2438d77) to head (87f553c).
Report is 2 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #7098      +/-   ##
============================================
+ Coverage     52.67%   53.18%   +0.50%     
- Complexity     6697     6798     +101     
============================================
  Files          1134     1133       -1     
  Lines         40310    40302       -8     
  Branches       4722     4723       +1     
============================================
+ Hits          21234    21435     +201     
+ Misses        17043    16820     -223     
- Partials       2033     2047      +14     

see 23 files with indirect coverage changes

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit 6799dc9 into apache:2.x Jan 13, 2025
8 checks passed
@psxjoy psxjoy deleted the common-unit-test branch January 13, 2025 02:59
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add unit test to fescar-common module

2 participants