Skip to content

Conversation

@funky-eyes
Copy link
Contributor

… NacosMockTest in parallel

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #7091

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added this to the 2.4.0 milestone Jan 3, 2025
@funky-eyes funky-eyes added module/config config module module/test test module type: test test case and removed module/test test module labels Jan 3, 2025
@codecov
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.60%. Comparing base (dc08160) to head (a9619fe).
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #7092      +/-   ##
============================================
+ Coverage     52.58%   52.60%   +0.01%     
  Complexity     6681     6681              
============================================
  Files          1131     1131              
  Lines         40277    40277              
  Branches       4723     4721       -2     
============================================
+ Hits          21179    21186       +7     
+ Misses        17072    17065       -7     
  Partials       2026     2026              

see 3 files with indirect coverage changes

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 6310ce3 into apache:2.x Jan 3, 2025
7 checks passed
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module/config config module type: test test case

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NacosMockTest.getConfig:82 expected: <null> but was: <TEST>

2 participants