optimize: fast fail when channel is null #7075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7075 +/- ##
=========================================
Coverage 52.65% 52.65%
- Complexity 6665 6666 +1
=========================================
Files 1129 1129
Lines 40168 40168
Branches 4708 4708
=========================================
+ Hits 21150 21152 +2
Misses 16999 16999
+ Partials 2019 2017 -2
|
YvCeung
pushed a commit
to YvCeung/incubator-seata
that referenced
this pull request
Dec 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
This PR enhances the
RmNettyRemotingClient#sendRegisterMessagemethod by improving its error handling when thechannelparameter isnull.Ⅱ. Does this pull request fix one issue?
Fixes #7057
Ⅲ. Why don't you add test cases (unit test/integration test)?
org.apache.seata.core.rpc.netty.RmNettyClientTest#testSendAsyncRequestWithNullChannelLogsWarning
Ⅳ. Describe how to verify it
mvn test