-
Notifications
You must be signed in to change notification settings - Fork 8.9k
optimize: add namingserver jib #7051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
# Conflicts: # changes/zh-cn/2.x.md
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7051 +/- ##
============================================
- Coverage 52.78% 52.77% -0.02%
+ Complexity 6645 6643 -2
============================================
Files 1126 1126
Lines 40142 40142
Branches 4709 4707 -2
============================================
- Hits 21189 21183 -6
- Misses 16939 16944 +5
- Partials 2014 2015 +1 |
| # limitations under the License. | ||
| # | ||
|
|
||
| # entrypoint for server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
entrypoint for namingserver
…ver-jib # Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
slievrly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
fixes #7008 |
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews