Skip to content

Conversation

@ujjboy
Copy link
Member

@ujjboy ujjboy commented Nov 28, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

add some test case.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.70%. Comparing base (556a734) to head (f5de07e).
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #7030      +/-   ##
============================================
+ Coverage     52.60%   52.70%   +0.10%     
- Complexity     6590     6609      +19     
============================================
  Files          1126     1126              
  Lines         40020    40020              
  Branches       4700     4700              
============================================
+ Hits          21053    21094      +41     
+ Misses        16957    16915      -42     
- Partials       2010     2011       +1     
Files with missing lines Coverage Δ
...java/org/apache/seata/common/LockStrategyMode.java 0.00% <ø> (ø)

... and 10 files with indirect coverage changes

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't suggest to add an author or personal information.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 9a6ece1 into apache:2.x Nov 28, 2024
7 checks passed
@slievrly slievrly added this to the 2.3.0 milestone Nov 28, 2024
@ujjboy ujjboy deleted the add_test_case branch November 28, 2024 12:32
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants