Skip to content

optimize: fail fast, when all server channel not available #7023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
funky-eyes merged 5 commits into from
Nov 25, 2024
Merged

optimize: fail fast, when all server channel not available #7023

funky-eyes merged 5 commits into from
Nov 25, 2024
+8 −10

Conversation

@jsbxyyx
Copy link
Member

@jsbxyyx jsbxyyx commented Nov 22, 2024 •
edited
Loading

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

optimize: fail fast, when all server channel not available

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@jsbxyyx jsbxyyx changed the title When all server channel not available, fail fast optimize: when all server channel not available, fail fast Nov 22, 2024
@jsbxyyx jsbxyyx changed the title optimize: when all server channel not available, fail fast optimize: fail fast, when all server channel not available, Nov 22, 2024
@jsbxyyx jsbxyyx changed the title optimize: fail fast, when all server channel not available, optimize: fail fast, when all server channel not available Nov 22, 2024
@jsbxyyx jsbxyyx closed this Nov 24, 2024
@jsbxyyx jsbxyyx reopened this Nov 24, 2024
@funky-eyes funky-eyes added this to the 2.3.0 milestone Nov 25, 2024
funky-eyes
funky-eyes approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes
Copy link
Contributor

funky-eyes commented Nov 25, 2024

Error: /home/runner/work/incubator-seata/incubator-seata/server/src/main/java/org/apache/seata/server/controller/VGroupMappingController.java:21:8: Unused import - org.apache.seata.common.util.StringUtils. [UnusedImports]
Error: /home/runner/work/incubator-seata/incubator-seata/server/src/main/java/org/apache/seata/server/controller/VGroupMappingController.java:32:8: Unused import - javax.annotation.PostConstruct. [UnusedImports]
Error: /home/runner/work/incubator-seata/incubator-seata/server/src/main/java/org/apache/seata/server/controller/VGroupMappingController.java:34:15: Unused import - org.apache.seata.common.ConfigurationKeys.FILE_CONFIG_SPLIT_CHAR. [UnusedImports]
Error: /home/runner/work/incubator-seata/incubator-seata/server/src/main/java/org/apache/seata/server/controller/VGroupMappingController.java:35:15: Unused import - org.apache.seata.common.ConfigurationKeys.FILE_ROOT_REGISTRY. [UnusedImports]
Error: /home/runner/work/incubator-seata/incubator-seata/server/src/main/java/org/apache/seata/server/controller/VGroupMappingController.java:36:15: Unused import - org.apache.seata.common.ConfigurationKeys.FILE_ROOT_TYPE. [UnusedImports]
Error: /home/runner/work/incubator-seata/incubator-seata/server/src/main/java/org/apache/seata/server/controller/VGroupMappingController.java:37:15: Unused import - org.apache.seata.common.ConfigurationKeys.NAMING_SERVER. [UnusedImports]

@codecov
Copy link

codecov bot commented Nov 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.62%. Comparing base (a3fd17c) to head (1b67a03).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
...eata/core/rpc/netty/NettyClientChannelManager.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #7023      +/-   ##
============================================
- Coverage     52.63%   52.62%   -0.01%     
+ Complexity     6595     6592       -3     
============================================
  Files          1126     1126              
  Lines         40007    40004       -3     
  Branches       4696     4694       -2     
============================================
- Hits          21058    21053       -5     
+ Misses        16944    16943       -1     
- Partials       2005     2008       +3
Files with missing lines Coverage Δ
...ata/server/controller/VGroupMappingController.java 9.52% <ø> (-6.48%) ⬇️
...eata/core/rpc/netty/NettyClientChannelManager.java 59.87% <0.00%> (-0.39%) ⬇️

... and 4 files with indirect coverage changes

---- 🚨 Try these New Features:

@funky-eyes funky-eyes merged commit 34990eb into apache:2.x Nov 25, 2024
7 checks passed
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
@jsbxyyx
optimize: fail fast, when all server channel not available (apache#7023)
a326a33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@funky-eyes funky-eyes funky-eyes approved these changes

Assignees

No one assigned

Labels

module/core core module type: optimize

Projects

None yet

Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jsbxyyx @funky-eyes