Skip to content

Conversation

@GoodBoyCoder
Copy link
Contributor

@GoodBoyCoder GoodBoyCoder commented Nov 10, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

If the before and agter images are both empty, skip prepareUndoLog directly

Ⅱ. Does this pull request fix one issue?

fixes #6976

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

make an updateJoin statement with an empty query result to test

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.65%. Comparing base (60a81b1) to head (9aaa658).
Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
...datasource/exec/mysql/MySQLUpdateJoinExecutor.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x    #6994   +/-   ##
=========================================
  Coverage     52.65%   52.65%           
- Complexity     6571     6576    +5     
=========================================
  Files          1126     1126           
  Lines         39942    39945    +3     
  Branches       4680     4682    +2     
=========================================
+ Hits          21031    21034    +3     
- Misses        16911    16913    +2     
+ Partials       2000     1998    -2     
Files with missing lines Coverage Δ
...datasource/exec/mysql/MySQLUpdateJoinExecutor.java 78.26% <75.00%> (-0.23%) ⬇️

... and 4 files with indirect coverage changes

@funky-eyes funky-eyes added this to the 2.3.0 milestone Nov 11, 2024
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. mode: AT AT transaction mode module/rm-datasource rm-datasource module labels Nov 11, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 7930f31 into apache:2.x Nov 11, 2024
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mode: AT AT transaction mode module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update没有更新任何数据,prepareUndoLog时报错”images can not be null“

2 participants