bugfix: fix ConcurrentModificationException in SessionConverter.convertBranchSession #6943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6943 +/- ##
============================================
+ Coverage 52.68% 52.69% +0.01%
- Complexity 6559 6560 +1
============================================
Files 1122 1122
Lines 39861 39862 +1
Branches 4666 4668 +2
============================================
+ Hits 21001 21007 +6
+ Misses 16862 16860 -2
+ Partials 1998 1995 -3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
ConcurrentModificationExceptioninSessionConverter.convertBranchSession(List<BranchSession> branchSessions).README.md.Ⅱ. Does this pull request fix one issue?
fix #6895
Ⅲ. Why don't you add test cases (unit test/integration test)?
I have added test cases and all cases have passed,not applicable.
已添加相关测试用例并且用例通过，不适用该选项。
Ⅳ. Describe how to verify it
Run
SessionConverterTestⅤ. Special notes for reviews
Since the issue cannot be consistently reproduced in a multithreaded environment, I configured the test cases to run 100 times. However, this method is too resource-intensive and time-consuming. I decided to comment out those test cases and will reevaluate their necessity later.
多线程问题无法100%复现，因此测试用例设置为重复运行100次。但是这样的测试用例太过于消耗运行资源和时间。我暂时将对应的测试用例注释掉，待评估后再正常使用。