bugfix: resolve issue in Raft model a follower's crash may lead to the continued use of expired tokens #6925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… client to continued use of expired tokens
funky-eyes
added
first-time contributor
funky-eyes
reviewed
Oct 15, 2024
| - [[#6899](https://github.com/apache/incubator-seata/pull/6899)] 修复file.conf打包后的读取 | ||
| - [[#6890](https://github.com/apache/incubator-seata/pull/6890)] 修复saga设计json转标准json过程中: 子状态机补偿节点无法被识别 | ||
| - [[#6907](https://github.com/apache/incubator-seata/pull/6907)] 修复Codecov未生成报告的问题 | ||
| - [[#6925](https://github.com/apache/incubator-seata/pull/6925)] 修复Raft模式下，Follower崩溃可能导致Client继续使用过期令牌的问题 |
Contributor
There was a problem hiding this comment.
最下方的开发者信息也需要登记
The developer information at the bottom also requires registration.
| - [[#6899](https://github.com/apache/incubator-seata/pull/6899)] fix file.conf read failed after package | ||
| - [[#6890](https://github.com/apache/incubator-seata/pull/6890)] fix designerJson to standardJson: subStateMachine compensateState cannot be recognized | ||
| - [[#6907](https://github.com/apache/incubator-seata/pull/6907)] fix the issue of Codecov not generating reports | ||
| - [[#6925](https://github.com/apache/incubator-seata/pull/6925)] fix the issue in Raft model a follower's crash may lead to the continued use of expired tokens |
Contributor
There was a problem hiding this comment.
最下方的开发者信息也需要登记
The developer information at the bottom also requires registration.
Contributor
Author
There was a problem hiding this comment.
Thanks for your reminder, the developer info has been added.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6925 +/- ##
============================================
+ Coverage 51.72% 51.79% +0.07%
- Complexity 6456 6459 +3
============================================
Files 1122 1122
Lines 39857 39857
Branches 4668 4668
============================================
+ Hits 20616 20645 +29
+ Misses 17280 17252 -28
+ Partials 1961 1960 -1
|
LQxdu
added a commit
to LQxdu/incubator-seata
that referenced
this pull request
Oct 16, 2024
bugfix: resolve issue in Raft model a follower's crash may lead to the continued use of expired tokens (apache#6925)
1 task
YvCeung
pushed a commit
to YvCeung/incubator-seata
that referenced
this pull request
Dec 25, 2025
…e continued use of expired tokens (apache#6925)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… client to continued use of expired tokens
Ⅰ. Describe what this PR did
解决raft模式下，follower崩溃可能导致client继续使用过期令牌的问题
resolve issue in Raft model where follower crashes could lead client to continued use of expired tokens
Ⅱ. Does this pull request fix one issue?
fixes #6917
In RaftRegistryServiceImpl#refreshToken, the tokenTimeStamp is updated before the request to obtain the token is sent, and there is no check for whether the HTTP status is normal.
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews