-
Notifications
You must be signed in to change notification settings - Fork 8.9k
optimize:Use the openjdk image of eclipse-temurin as the base image #6918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6918 +/- ##
============================================
- Coverage 52.52% 51.80% -0.73%
+ Complexity 6542 6459 -83
============================================
Files 1122 1122
Lines 39857 39857
Branches 4668 4668
============================================
- Hits 20936 20646 -290
- Misses 16925 17249 +324
+ Partials 1996 1962 -34 |
Co-authored-by: funkye <[email protected]>
wangliang181230
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
funky-eyes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Use the openjdk image of eclipse-temurin as the base image
Ⅱ. Does this pull request fix one issue?
fixes #6916
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews