Skip to content

Conversation

@xingfudeshi
Copy link
Member

@xingfudeshi xingfudeshi commented Oct 12, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Use the openjdk image of eclipse-temurin as the base image

Ⅱ. Does this pull request fix one issue?

fixes #6916

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

image image

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.80%. Comparing base (66bd3a4) to head (8538a8c).
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6918      +/-   ##
============================================
- Coverage     52.52%   51.80%   -0.73%     
+ Complexity     6542     6459      -83     
============================================
  Files          1122     1122              
  Lines         39857    39857              
  Branches       4668     4668              
============================================
- Hits          20936    20646     -290     
- Misses        16925    17249     +324     
+ Partials       1996     1962      -34     

see 35 files with indirect coverage changes

@funky-eyes funky-eyes added this to the 2.3.0 milestone Oct 13, 2024
Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace base image with temurin

3 participants