Skip to content

Conversation

@xjlgod
Copy link
Contributor

@xjlgod xjlgod commented Oct 3, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

fix #6888

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added this to the 2.3.0 milestone Oct 3, 2024
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/server server module labels Oct 3, 2024
@funky-eyes funky-eyes changed the title fix: fix file.conf read failed after package bugfix: fix file.conf read failed after package Oct 3, 2024

### bugfix:

- [[#6899](https://github.com/apache/incubator-seata/pull/6899)] fix: fix file.conf read failed after package
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [[#6899](https://github.com/apache/incubator-seata/pull/6899)] fix: fix file.conf read failed after package
- [[#6899](https://github.com/apache/incubator-seata/pull/6899)] fix file.conf read failed after package

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

*/
package org.apache.seata.config;

import org.slf4j.Logger;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

移到java包下方
Move below the java package

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have done.

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit b16f9cd into apache:2.x Oct 8, 2024
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module/server server module type: bug Category issues or prs related to bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Read file.conf in wrong path after package seata server

2 participants