Skip to content

optimize: Log args mismatch #6879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
funky-eyes merged 6 commits into from
Oct 8, 2024
Merged

optimize: Log args mismatch #6879

funky-eyes merged 6 commits into from
Oct 8, 2024

Conversation

@arrrnold17
Copy link
Contributor

@arrrnold17 arrrnold17 commented Sep 25, 2024 •
edited
Loading

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Resolved a logging error in the LOGGER.error() method where the number of placeholders did not match the number of provided arguments

Ⅱ. Does this pull request fix one issue?

fixed #6877

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

funky-eyes
funky-eyes reviewed Sep 26, 2024
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/apache/incubator-seata/blob/2.x/changes/zh-cn/2.x.md
https://github.com/apache/incubator-seata/blob/2.x/changes/en-us/2.x.md
请在上述md文件中登记pr信息和作者信息
Please register pr information and author information in the above md file

@funky-eyes
Copy link
Contributor

funky-eyes commented Sep 27, 2024

https://github.com/apache/incubator-seata/blob/2.x/changes/zh-cn/2.x.md https://github.com/apache/incubator-seata/blob/2.x/changes/en-us/2.x.md 请在上述md文件中登记pr信息和作者信息 Please register pr information and author information in the above md file

请看下这条信息
Please take a look at this message.

@funky-eyes funky-eyes changed the title Log args mismatch optimize: Log args mismatch Oct 8, 2024
@funky-eyes funky-eyes added this to the 2.3.0 milestone Oct 8, 2024
funky-eyes
funky-eyes approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit a0d0513 into apache:2.x Oct 8, 2024
@funky-eyes funky-eyes added the first-time contributor first-time contributor label Oct 8, 2024
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
@arrrnold17
optimize: Log args mismatch (apache#6879)
7aac1ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@funky-eyes funky-eyes funky-eyes approved these changes

Assignees

No one assigned

Labels

first-time contributor first-time contributor module/core core module type: optimize

Projects

None yet

Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

Fewer arguments provided (3) than placeholders specified (4)

2 participants

@arrrnold17 @funky-eyes