Skip to content

Conversation

@lightClouds917
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #6868

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@slievrly
Copy link
Member

slievrly commented Nov 5, 2024

PR has not been updated for a long time, can we start the review?

@codecov
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.83%. Comparing base (3bfc206) to head (64efb3a).
Report is 3 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6869      +/-   ##
============================================
+ Coverage     52.58%   52.83%   +0.25%     
- Complexity     6615     6660      +45     
============================================
  Files          1128     1128              
  Lines         40142    40142              
  Branches       4707     4705       -2     
============================================
+ Hits          21108    21209     +101     
+ Misses        17020    16921      -99     
+ Partials       2014     2012       -2     

see 14 files with indirect coverage changes

@lightClouds917 lightClouds917 changed the title [WIP]test:add test for seata-core test:add test for seata-core Nov 29, 2024
@lightClouds917
Copy link
Contributor Author

PR has not been updated for a long time, can we start the review?

i have resolved the conflict,please review

@slievrly slievrly changed the title test:add test for seata-core test: add test for seata-core Nov 30, 2024
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit a60588a into apache:2.x Nov 30, 2024
7 checks passed
@slievrly slievrly added this to the 2.3.0 milestone Nov 30, 2024
@slievrly slievrly added the type: test test case label Dec 1, 2024
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: test test case

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test:add test for seata-core

2 participants