-
Notifications
You must be signed in to change notification settings - Fork 8.9k
test: add test for seata-core #6869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
PR has not been updated for a long time, can we start the review? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6869 +/- ##
============================================
+ Coverage 52.58% 52.83% +0.25%
- Complexity 6615 6660 +45
============================================
Files 1128 1128
Lines 40142 40142
Branches 4707 4705 -2
============================================
+ Hits 21108 21209 +101
+ Misses 17020 16921 -99
+ Partials 2014 2012 -2 |
i have resolved the conflict,please review |
slievrly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #6868
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews