Skip to content

bugfix: rocksDB opens the same file multiple times #6845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
funky-eyes merged 3 commits into from
Sep 12, 2024
Merged

bugfix: rocksDB opens the same file multiple times #6845

funky-eyes merged 3 commits into from
Sep 12, 2024

Conversation

@funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Sep 12, 2024 •
edited
Loading

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #6844

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/server server module labels Sep 12, 2024
@funky-eyes funky-eyes added this to the 2.2.0 milestone Sep 12, 2024
@codecov
Copy link

codecov bot commented Sep 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.37%. Comparing base (42f3ae7) to head (b6406a1).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...g/apache/seata/server/instance/ServerInstance.java 0.00% 1 Missing ⚠️
...org/apache/seata/server/session/SessionHolder.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6845      +/-   ##
============================================
+ Coverage     52.34%   52.37%   +0.03%     
- Complexity     6382     6383       +1     
============================================
  Files          1081     1081              
  Lines         37617    37615       -2     
  Branches       4464     4462       -2     
============================================
+ Hits          19690    19701      +11     
+ Misses        15974    15962      -12     
+ Partials       1953     1952       -1
Files with missing lines Coverage Δ
...g/apache/seata/server/instance/ServerInstance.java 9.37% <0.00%> (-3.13%) ⬇️
...org/apache/seata/server/session/SessionHolder.java 51.31% <0.00%> (+0.01%) ⬆️

... and 4 files with indirect coverage changes

@funky-eyes funky-eyes merged commit 1df92e9 into apache:2.x Sep 12, 2024
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
@funky-eyes
bugfix: rocksDB opens the same file multiple times (apache#6845)
3ae2516
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leizhiyuan leizhiyuan leizhiyuan approved these changes

@lovepoem lovepoem Awaiting requested review from lovepoem

@xingfudeshi xingfudeshi Awaiting requested review from xingfudeshi

Assignees

No one assigned

Labels

module/server server module type: bug Category issues or prs related to bug.

Projects

None yet

Milestone

2.2.0

Development

Successfully merging this pull request may close these issues.

lock hold by current process sessionStore/raft/9091/default/log/LOCK: No locks available

2 participants

@funky-eyes @leizhiyuan