Skip to content

bugfix: Unsafe deserialization in processorYaml.java #6839 #6840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xingfudeshi merged 5 commits into from
Sep 11, 2024
Merged

bugfix: Unsafe deserialization in processorYaml.java #6839 #6840

xingfudeshi merged 5 commits into from
Sep 11, 2024

Conversation

@LegGasai
Copy link
Contributor

@LegGasai LegGasai commented Sep 10, 2024 •
edited by funky-eyes
Loading

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

fixes #6839

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.34%. Comparing base (fa6bdda) to head (58e69d4).
Report is 2 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6840      +/-   ##
============================================
- Coverage     52.38%   52.34%   -0.04%     
+ Complexity     6384     6382       -2     
============================================
  Files          1081     1081              
  Lines         37617    37617              
  Branches       4464     4462       -2     
============================================
- Hits          19706    19692      -14     
- Misses        15961    15973      +12     
- Partials       1950     1952       +2
Files with missing lines Coverage Δ
...g/apache/seata/config/processor/ProcessorYaml.java 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@funky-eyes funky-eyes changed the title bufix: Unsafe deserialization in processorYaml.java #6839 bugfix: Unsafe deserialization in processorYaml.java #6839 Sep 11, 2024
funky-eyes
funky-eyes approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.2.0 milestone Sep 11, 2024
@funky-eyes funky-eyes added module/config config module type: optimize type: bug Category issues or prs related to bug. and removed type: optimize labels Sep 11, 2024
xingfudeshi
xingfudeshi approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit c0d2ac5 into apache:2.x Sep 11, 2024
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
@LegGasai
bugfix: Unsafe deserialization in processorYaml.java apache#6839 (apa…
ffdfdc4 
…che#6840)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@funky-eyes funky-eyes funky-eyes approved these changes

@xingfudeshi xingfudeshi xingfudeshi approved these changes

Assignees

No one assigned

Labels

module/config config module type: bug Category issues or prs related to bug.

Projects

None yet

Milestone

2.2.0

Development

Successfully merging this pull request may close these issues.

Unsafe deserialization in processorYaml.java

4 participants

@LegGasai @funky-eyes @xingfudeshi @LegendGasai