Skip to content

Conversation

@ggbocoder
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

ggbocoder and others added 28 commits January 2, 2024 10:47
# Conflicts:
#	changes/en-us/2.x.md
#	changes/zh-cn/2.x.md
# Conflicts:
#	changes/zh-cn/2.x.md
…fail

# Conflicts:
#	changes/en-us/2.x.md
#	changes/zh-cn/2.x.md
@codecov
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 52.52%. Comparing base (242d92c) to head (4930826).
Report is 4 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ache/seata/namingserver/manager/NamingManager.java 50.00% 2 Missing and 3 partials ⚠️
...ache/seata/namingserver/entity/bo/NamespaceBO.java 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6817      +/-   ##
============================================
+ Coverage     52.30%   52.52%   +0.22%     
+ Complexity     6387     6385       -2     
============================================
  Files          1080     1080              
  Lines         37552    37558       +6     
  Branches       4447     4450       +3     
============================================
+ Hits          19641    19729      +88     
+ Misses        15977    15881      -96     
- Partials       1934     1948      +14     
Files with missing lines Coverage Δ
...ata/server/controller/VGroupMappingController.java 16.00% <ø> (+1.18%) ⬆️
...ache/seata/namingserver/entity/bo/NamespaceBO.java 59.09% <50.00%> (-14.60%) ⬇️
...ache/seata/namingserver/manager/NamingManager.java 55.50% <50.00%> (-1.24%) ⬇️

... and 17 files with indirect coverage changes

@funky-eyes funky-eyes added this to the 2.2.0 milestone Sep 6, 2024
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/namingserver module/server server module labels Sep 6, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 145b33c into apache:2.x Sep 6, 2024
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module/namingserver module/server server module type: bug Category issues or prs related to bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants