optimize: fall back to any of available cluster address when query cluster address is empty #6797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@funky-eyes PTAL |
funky-eyes
reviewed
Aug 29, 2024
.../seata-discovery-core/src/main/java/org/apache/seata/discovery/registry/RegistryService.java
Outdated
Show resolved
Hide resolved
.../seata-discovery-core/src/main/java/org/apache/seata/discovery/registry/RegistryService.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/seata/discovery/registry/namingserver/NamingserverRegistryServiceImpl.java
Show resolved
Hide resolved
...n/java/org/apache/seata/discovery/registry/namingserver/NamingserverRegistryServiceImpl.java
Show resolved
Hide resolved
added 2 commits
August 29, 2024 16:12
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6797 +/- ##
============================================
- Coverage 52.19% 52.16% -0.03%
- Complexity 6310 6312 +2
============================================
Files 1067 1067
Lines 37278 37303 +25
Branches 4427 4430 +3
============================================
+ Hits 19456 19459 +3
- Misses 15889 15912 +23
+ Partials 1933 1932 -1
|
added 2 commits
August 29, 2024 17:45
funky-eyes
added
type: bug
funky-eyes
reviewed
Aug 30, 2024
added 2 commits
August 30, 2024 09:47
1 task
YvCeung
pushed a commit
to YvCeung/incubator-seata
that referenced
this pull request
Dec 25, 2025
…uster address is empty (apache#6797)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
fall back to any of available cluster address when query cluster address is empty
Ⅱ. Does this pull request fix one issue?
fix: #6790
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews