Skip to content

Conversation

@funky-eyes
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added this to the 2.2.0 milestone Aug 26, 2024
@codecov
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 52.20%. Comparing base (256c4a3) to head (5d2e735).
Report is 2 commits behind head on 2.x.

Files Patch % Lines
.../namingserver/NamingserverRegistryServiceImpl.java 0.00% 5 Missing ⚠️
...ata/server/controller/VGroupMappingController.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6783      +/-   ##
============================================
+ Coverage     52.17%   52.20%   +0.02%     
  Complexity     6292     6292              
============================================
  Files          1065     1065              
  Lines         37199    37193       -6     
  Branches       4413     4411       -2     
============================================
+ Hits          19410    19415       +5     
+ Misses        15870    15862       -8     
+ Partials       1919     1916       -3     
Files Coverage Δ
...ata/server/controller/VGroupMappingController.java 14.81% <66.66%> (ø)
.../namingserver/NamingserverRegistryServiceImpl.java 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit dadaa6b into apache:2.x Aug 28, 2024
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants