Skip to content

bugfix: fix tcc dead lock #6769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
funky-eyes merged 6 commits into from
Aug 22, 2024
Merged

bugfix: fix tcc dead lock #6769

funky-eyes merged 6 commits into from
Aug 22, 2024

Conversation

@iAmClever
Copy link
Contributor

@iAmClever iAmClever commented Aug 19, 2024 •
edited
Loading

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #6679

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@iAmClever iAmClever force-pushed the clever_fix_tcc_dead_lock branch from ef83bc3 to 9ffc3db Compare August 19, 2024 15:40
@iAmClever iAmClever changed the title fix tcc dead lock bugfix: fix tcc dead lock Aug 21, 2024
@codecov
Copy link

codecov bot commented Aug 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 13.33333% with 26 lines in your changes missing coverage. Please review.

Project coverage is 52.14%. Comparing base (5617405) to head (b52c30e).
Report is 1 commits behind head on 2.x.

Files Patch % Lines
.../org/apache/seata/rm/fence/SpringFenceHandler.java 0.00% 26 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6769      +/-   ##
============================================
- Coverage     52.34%   52.14%   -0.21%     
+ Complexity     6304     6287      -17     
============================================
  Files          1064     1064              
  Lines         37167    37194      +27     
  Branches       4409     4412       +3     
============================================
- Hits          19456    19395      -61     
- Misses        15793    15884      +91     
+ Partials       1918     1915       -3
Files Coverage Δ
...c/main/java/org/apache/seata/common/Constants.java 100.00% <ø> (ø)
...va/org/apache/seata/rm/tcc/TCCResourceManager.java 50.00% <100.00%> (+2.32%) ⬆️
.../org/apache/seata/rm/fence/SpringFenceHandler.java 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes

@funky-eyes funky-eyes added this to the 2.2.0 milestone Aug 22, 2024
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. mode: TCC TCC transaction mode module/tcc tcc module labels Aug 22, 2024
funky-eyes
funky-eyes approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 5601c36 into apache:2.x Aug 22, 2024
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
@iAmClever
bugfix: fix tcc dead lock (apache#6769)
05d1f36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@funky-eyes funky-eyes funky-eyes approved these changes

Assignees

No one assigned

Labels

mode: TCC TCC transaction mode module/tcc tcc module type: bug Category issues or prs related to bug.

Projects

None yet

Milestone

2.2.0

2 participants

@iAmClever @funky-eyes