Skip to content

Conversation

@wt-better
Copy link
Contributor

@wt-better wt-better commented Aug 3, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

  1. deserialize performance optimize, avoid exceptions during deserialization
  2. avoid array copy in deserialize

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

test deserialize method performance

Ⅴ. Special notes for reviews

byteBuffer.get(body);
ByteBuffer in = ByteBuffer.wrap(body);
//new Messgae
ByteBuffer in = byteBuffer.slice();

This comment was marked as resolved.

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit c1515ac into apache:2.x Aug 6, 2024
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants