Skip to content

Conversation

@ggbocoder
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

add namingserver distribution in windows

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 70.73171% with 24 lines in your changes missing coverage. Please review.

Project coverage is 50.71%. Comparing base (933b492) to head (7e2434d).
Report is 36 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6654      +/-   ##
============================================
- Coverage     51.13%   50.71%   -0.42%     
- Complexity     5317     5702     +385     
============================================
  Files           950     1034      +84     
  Lines         33448    35854    +2406     
  Branches       4048     4253     +205     
============================================
+ Hits          17103    18183    +1080     
- Misses        14666    15847    +1181     
- Partials       1679     1824     +145     
Files Coverage Δ
...c/main/java/org/apache/seata/common/Constants.java 100.00% <ø> (ø)
...in/java/org/apache/seata/common/metadata/Node.java 79.06% <100.00%> (-5.15%) ⬇️
...n/java/io/seata/core/constants/DubboConstants.java 0.00% <ø> (ø)
...io/seata/core/rpc/netty/RmNettyRemotingClient.java 0.00% <ø> (ø)
...eata/namingserver/controller/NamingController.java 37.83% <ø> (ø)
...ta/namingserver/manager/ClusterWatcherManager.java 28.26% <ø> (ø)
...e/seata/namingserver/pojo/AbstractClusterData.java 25.00% <ø> (ø)
...er/cluster/raft/serializer/CustomDeserializer.java 0.00% <ø> (ø)
...cluster/raft/serializer/JacksonBoltSerializer.java 40.00% <ø> (ø)
...rg/apache/seata/namingserver/pojo/ClusterData.java 63.63% <75.00%> (ø)
... and 1 more

... and 109 files with indirect coverage changes

@funky-eyes funky-eyes added this to the 2.2.0 milestone Jul 8, 2024
@funky-eyes funky-eyes changed the title optimize:add namingserver distribution optimize: add namingserver distribution Jul 8, 2024
Copy link
Contributor

@lightClouds917 lightClouds917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add change log

@ggbocoder
Copy link
Contributor Author

please add change log

done

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit cbbfa22 into apache:2.x Jul 12, 2024
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants