Skip to content

Conversation

@slievrly
Copy link
Member

@slievrly slievrly commented Jul 7, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

add license header for proto file

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.41%. Comparing base (933b492) to head (6cb28b3).
Report is 28 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6651      +/-   ##
============================================
- Coverage     51.13%   50.41%   -0.72%     
- Complexity     5317     5613     +296     
============================================
  Files           950     1023      +73     
  Lines         33448    35440    +1992     
  Branches       4048     4218     +170     
============================================
+ Hits          17103    17867     +764     
- Misses        14666    15801    +1135     
- Partials       1679     1772      +93     

see 116 files with indirect coverage changes

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please register the pr information.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit 1e0eae6 into apache:2.x Jul 7, 2024
slievrly added a commit to slievrly/fescar that referenced this pull request Jul 13, 2024
@slievrly slievrly added this to the 2.2.0 milestone Jul 20, 2024
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Process

Development

Successfully merging this pull request may close these issues.

4 participants