Skip to content

Conversation

@slievrly
Copy link
Member

@slievrly slievrly commented Jul 7, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

add license header for SPI file

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.24%. Comparing base (933b492) to head (2540eba).
Report is 28 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6650      +/-   ##
============================================
- Coverage     51.13%   50.24%   -0.90%     
- Complexity     5317     5596     +279     
============================================
  Files           950     1023      +73     
  Lines         33448    35440    +1992     
  Branches       4048     4218     +170     
============================================
+ Hits          17103    17806     +703     
- Misses        14666    15867    +1201     
- Partials       1679     1767      +88     

see 123 files with indirect coverage changes

@funky-eyes funky-eyes added this to the 2.2.0 milestone Jul 7, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes
Copy link
Contributor

Please register the pr information.

@slievrly
Copy link
Member Author

slievrly commented Jul 7, 2024

Please register the pr information.

PR change will be added after commit cherry pick to 2.1.0.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit f0f1442 into apache:2.x Jul 7, 2024
slievrly added a commit to slievrly/fescar that referenced this pull request Jul 13, 2024
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Process

Development

Successfully merging this pull request may close these issues.

4 participants