Skip to content

Conversation

@gggyd123
Copy link
Contributor

@gggyd123 gggyd123 commented Feb 27, 2024

…_LOG table on SQL server

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

fix sql exception when checking for the existence of the UNDO_LOG table on SQL server

Ⅱ. Does this pull request fix one issue?

fixes #6379

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 52.37%. Comparing base (3c98058) to head (73795e5).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6380      +/-   ##
============================================
- Coverage     52.40%   52.37%   -0.03%     
+ Complexity     5244     5240       -4     
============================================
  Files           924      924              
  Lines         32066    32068       +2     
  Branches       3833     3833              
============================================
- Hits          16805    16797       -8     
- Misses        13607    13613       +6     
- Partials       1654     1658       +4     
Files Coverage Δ
...source/undo/sqlserver/SqlServerUndoLogManager.java 11.42% <50.00%> (+2.33%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.1.0 milestone Feb 28, 2024
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/rm-datasource rm-datasource module labels Feb 28, 2024
@funky-eyes funky-eyes merged commit 87b6e5f into apache:2.x Feb 28, 2024
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2.0版本中,client检查UNDO_LOG表是否存在适合,存在问题

3 participants