Skip to content

Conversation

@PeppaO
Copy link
Contributor

@PeppaO PeppaO commented Jan 23, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #6284

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e9281f0) 51.08% compared to head (bd42e3a) 51.04%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6291      +/-   ##
============================================
- Coverage     51.08%   51.04%   -0.05%     
+ Complexity     5098     5097       -1     
============================================
  Files           918      918              
  Lines         32038    32038              
  Branches       3866     3866              
============================================
- Hits          16367    16353      -14     
- Misses        14092    14106      +14     
  Partials       1579     1579              
Files Coverage Δ
...ver/spring/listener/ServerApplicationListener.java 42.22% <0.00%> (-2.23%) ⬇️

... and 4 files with indirect coverage changes

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.1.0 milestone Jan 23, 2024
@funky-eyes funky-eyes merged commit 36e6e41 into apache:2.x Jan 23, 2024
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Seata-server is developed in idea and cannot output logs

3 participants