Skip to content

Conversation

@slievrly
Copy link
Member

@slievrly slievrly commented Jan 18, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

optimize ProtocolV1SerializerTest failed

Ⅱ. Does this pull request fix one issue?

fixes #6277

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@slievrly slievrly changed the title optimize: optimize ProtocolV1SerializerTest failed bugfix: fix ProtocolV1SerializerTest failed Jan 18, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (3351fcf) 51.07% compared to head (f4f3831) 51.10%.
Report is 4 commits behind head on 2.x.

❗ Current head f4f3831 differs from pull request most recent head b2b9b7d. Consider uploading reports for the commit b2b9b7d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6278      +/-   ##
============================================
+ Coverage     51.07%   51.10%   +0.02%     
+ Complexity     5097     5096       -1     
============================================
  Files           918      918              
  Lines         32031    32038       +7     
  Branches       3865     3866       +1     
============================================
+ Hits          16361    16373      +12     
+ Misses        14097    14088       -9     
- Partials       1573     1577       +4     
Files Coverage Δ
.../io/seata/core/rpc/netty/v1/ProtocolV1Decoder.java 14.54% <33.33%> (+4.12%) ⬆️

... and 3 files with indirect coverage changes

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/serializer serializer module labels Jan 22, 2024
@funky-eyes funky-eyes added this to the 2.1.0 milestone Jan 22, 2024
@funky-eyes funky-eyes merged commit 0ac8158 into apache:2.x Jan 22, 2024
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module/serializer serializer module type: bug Category issues or prs related to bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

seata-test UT failed

3 participants