Skip to content

Conversation

@PeppaO
Copy link
Contributor

@PeppaO PeppaO commented Jan 12, 2024

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

使用seata-all sdk,在raft mode下不能读取到registry的配置

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

seata-all: 2.0.0
seata raft 集群

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (17358bb) 50.96% compared to head (611abfc) 51.03%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6256      +/-   ##
============================================
+ Coverage     50.96%   51.03%   +0.07%     
- Complexity     5089     5094       +5     
============================================
  Files           917      917              
  Lines         32022    32022              
  Branches       3862     3862              
============================================
+ Hits          16321    16344      +23     
+ Misses        14129    14109      -20     
+ Partials       1572     1569       -3     
Files Coverage Δ
...scovery/registry/raft/RaftRegistryServiceImpl.java 17.77% <100.00%> (ø)

... and 4 files with indirect coverage changes

@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/discovery discovery module labels Jan 12, 2024
@funky-eyes funky-eyes added this to the 2.1.0 milestone Jan 12, 2024
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit ea9c54f into apache:2.x Jan 12, 2024
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module/discovery discovery module type: bug Category issues or prs related to bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants