optimize: remove the useless file #6192
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6192 +/- ##
=========================================
Coverage 48.99% 48.99%
+ Complexity 4782 4781 -1
=========================================
Files 915 915
Lines 31892 31892
Branches 3853 3853
=========================================
Hits 15624 15624
+ Misses 14706 14705 -1
- Partials 1562 1563 +1 |
slievrly
left a comment
slievrly
left a comment
There was a problem hiding this comment.
It looks like this file has been entirely commented out. I suggest we just delete it.
lightClouds917
changed the title
lightClouds917
changed the title
ok,i will delete it |
funky-eyes
left a comment
funky-eyes
left a comment
There was a problem hiding this comment.
我不理解为何要单独提pr删除该无用文件，而不是提交一份将相关测试用例完善的pr来去除这个无效文件？
I don't understand why I need to mention PR to delete this useless file separately, instead of submitting a PR that perfects the relevant test cases to remove this invalid file?
This pr has nothing to do with test cases ，it is intended to completely clean up the outdated license headers in the project, which is the point. After this pr, there is no “Copyright 1999-2019 Seata.io Group." |
5 participants
Ⅰ. Describe what this PR did
remove:the duplicate header
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews