Skip to content

Conversation

@funky-eyes
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #6177

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added the Do Not Merge Do not merge into develop label Dec 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (2.x@f63b29d). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##             2.x    #6182   +/-   ##
======================================
  Coverage       ?   48.94%           
  Complexity     ?     4774           
======================================
  Files          ?      915           
  Lines          ?    31890           
  Branches       ?     3853           
======================================
  Hits           ?    15607           
  Misses         ?    14718           
  Partials       ?     1565           

@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. dependencies Pull requests that update a dependency file and removed Do Not Merge Do not merge into develop labels Dec 21, 2023
@funky-eyes funky-eyes added this to the 2.1.0 milestone Dec 21, 2023
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 6b010d4 into apache:2.x Dec 21, 2023
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file type: bug Category issues or prs related to bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

guava-32.0.0-jre.jar zip file is empty

4 participants