Skip to content

bugfix: support jdk9+ compile code #6085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wangliang181230 merged 4 commits into from
Nov 27, 2023
Merged

bugfix: support jdk9+ compile code #6085

wangliang181230 merged 4 commits into from
Nov 27, 2023

Conversation

@funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Nov 27, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/core core module module/common common module module/server server module labels Nov 27, 2023
@funky-eyes funky-eyes added this to the 2.1.0 milestone Nov 27, 2023
@codecov
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #6085 (347f2eb) into 2.x (e32cb1c) will decrease coverage by 0.06%.
The diff coverage is 37.50%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6085      +/-   ##
============================================
- Coverage     49.55%   49.50%   -0.06%     
+ Complexity     4763     4760       -3     
============================================
  Files           908      909       +1     
  Lines         31375    31390      +15     
  Branches       3782     3782              
============================================
- Hits          15549    15540       -9     
- Misses        14289    14312      +23     
- Partials       1537     1538       +1
Files Coverage Δ
...atasource/undo/parser/ProtostuffUndoLogParser.java 55.71% <100.00%> (ø)
...ava/io/seata/serializer/seata/SeataSerializer.java 80.00% <100.00%> (ø)
...in/java/io/seata/server/session/BranchSession.java 79.45% <100.00%> (ø)
...in/java/io/seata/server/session/GlobalSession.java 72.96% <100.00%> (ø)
...torage/file/store/FileTransactionStoreManager.java 56.27% <100.00%> (ø)
.../seata/serializer/protobuf/ProtobufSerializer.java 0.00% <0.00%> (ø)
...rc/main/java/io/seata/common/util/BufferUtils.java 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

wangliang181230
wangliang181230 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangliang181230 wangliang181230 merged commit 3702ff8 into apache:2.x Nov 27, 2023
@open-digger-bot open-digger-bot bot mentioned this pull request Dec 4, 2023
Closed
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
@funky-eyes
bugfix: support jdk9+ compile code (apache#6085)
dbaa0f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wangliang181230 wangliang181230 wangliang181230 approved these changes

Assignees

No one assigned

Labels

module/common common module module/core core module module/server server module type: bug Category issues or prs related to bug.

Projects

None yet

Milestone

2.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@funky-eyes @wangliang181230