Skip to content

Conversation

@wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Nov 22, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

optimize: add git infos to jars.
添加git信息到jar包中。

图片

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

GoodBoyCoder and others added 30 commits February 1, 2023 10:40
@codecov
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #6071 (f536995) into 2.x (03e88d5) will decrease coverage by 0.33%.
Report is 1 commits behind head on 2.x.
The diff coverage is 25.19%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6071      +/-   ##
============================================
- Coverage     49.57%   49.24%   -0.33%     
- Complexity     4789     4790       +1     
============================================
  Files           909      913       +4     
  Lines         31416    31685     +269     
  Branches       3778     3824      +46     
============================================
+ Hits          15573    15604      +31     
- Misses        14305    14538     +233     
- Partials       1538     1543       +5     
Files Coverage Δ
...ommon/exception/AuthenticationFailedException.java 0.00% <0.00%> (ø)
.../io/seata/common/exception/RetryableException.java 0.00% <0.00%> (ø)
...re/properties/registry/RegistryRaftProperties.java 16.66% <10.00%> (-8.34%) ⬇️
...main/java/io/seata/common/util/HttpClientUtil.java 0.00% <0.00%> (ø)
...scovery/registry/raft/RaftRegistryServiceImpl.java 16.73% <36.47%> (ø)

... and 11 files with indirect coverage changes

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangliang181230 wangliang181230 changed the base branch from develop to 2.x November 22, 2023 14:53
# Conflicts:
#	.github/workflows/build.yml
#	.github/workflows/test-druid.yml
#	.github/workflows/test.yml
#	README.md
#	build/pom.xml
#	changes/en-us/1.7.1.md
#	changes/en-us/2.0.0.md
#	changes/en-us/develop.md
#	changes/zh-cn/1.7.0.md
#	changes/zh-cn/1.7.1.md
#	changes/zh-cn/2.0.0.md
#	changes/zh-cn/develop.md
#	common/src/test/java/io/seata/common/loader/ExtensionDefinitionTest.java
#	compressor/seata-compressor-7z/pom.xml
#	compressor/seata-compressor-7z/src/main/java/io/seata/compressor/sevenz/SevenZCompressor.java
#	compressor/seata-compressor-7z/src/test/java/io/seata/compressor/sevenz/SevenZCompressorTest.java
#	compressor/seata-compressor-7z/src/test/java/io/seata/compressor/sevenz/SevenZUtilTest.java
#	config/seata-config-core/src/test/java/io/seata/config/ConfigTypeTest.java
#	config/seata-config-core/src/test/java/io/seata/config/ConfigurationCacheTests.java
#	console/src/main/resources/static/console-fe/package-lock.json
#	console/src/main/resources/static/console-fe/package.json
#	console/src/main/resources/static/js/main.js
#	core/src/main/java/io/seata/core/rpc/netty/NettyClientChannelManager.java
#	core/src/main/java/io/seata/core/store/db/sql/lock/DmLockStoreSql.java
#	core/src/main/resources/META-INF/services/io.seata.core.store.db.sql.lock.LockStoreSql
#	core/src/main/resources/META-INF/services/io.seata.core.store.db.sql.log.LogStoreSqls
#	core/src/test/java/io/seata/core/protocol/VersionTest.java
#	dependencies/pom.xml
#	discovery/seata-discovery-core/src/main/java/io/seata/discovery/registry/FileRegistryServiceImpl.java
#	discovery/seata-discovery-raft/src/main/java/io/seata/discovery/registry/raft/RaftRegistryProvider.java
#	distribution/bin/seata-server.bat
#	distribution/bin/seata-server.sh
#	integration-tx-api/src/main/java/io/seata/integration/tx/api/interceptor/SeataInterceptorPosition.java
#	integration-tx-api/src/main/java/io/seata/integration/tx/api/interceptor/handler/GlobalTransactionalInterceptorHandler.java
#	integration/grpc/src/main/java/io/seata/integration/grpc/interceptor/server/ServerListenerProxy.java
#	integration/rpc-core/pom.xml
#	integration/sofa-rpc/src/main/java/io/seata/integration/sofa/rpc/TransactionContextProviderFilter.java
#	rm-datasource/src/main/java/io/seata/rm/datasource/DataSourceProxy.java
#	rm-datasource/src/main/java/io/seata/rm/datasource/exec/ExecuteTemplate.java
#	rm-datasource/src/main/java/io/seata/rm/datasource/exec/MultiUpdateExecutor.java
#	rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/mysql/MySQLEscapeHandler.java
#	rm-datasource/src/main/java/io/seata/rm/datasource/undo/AbstractUndoExecutor.java
#	rm-datasource/src/main/java/io/seata/rm/datasource/util/SeataXAResource.java
#	rm-datasource/src/main/resources/META-INF/services/io.seata.rm.datasource.exec.InsertExecutor
#	rm-datasource/src/main/resources/META-INF/services/io.seata.rm.datasource.undo.UndoExecutorHolder
#	rm-datasource/src/main/resources/META-INF/services/io.seata.rm.datasource.undo.UndoLogManager
#	rm-datasource/src/main/resources/META-INF/services/io.seata.sqlparser.EscapeHandler
#	rm-datasource/src/main/resources/META-INF/services/io.seata.sqlparser.struct.TableMetaCache
#	rm-datasource/src/test/java/io/seata/rm/datasource/ColumnUtilsTest.java
#	rm-datasource/src/test/java/io/seata/rm/datasource/sql/SQLVisitorFactoryTest.java
#	rm-datasource/src/test/java/io/seata/rm/datasource/sql/handler/EscapeHandlerTest.java
#	rm-datasource/src/test/java/io/seata/rm/datasource/undo/polardbx/keyword/PolarDBXEscapeHandlerTest.java
#	saga/seata-saga-engine/src/main/java/io/seata/saga/engine/evaluation/exception/ExceptionMatchEvaluator.java
#	saga/seata-saga-statemachine-designer/package-lock.json
#	saga/seata-saga-tm/src/main/java/io/seata/saga/tm/DefaultSagaTransactionalTemplate.java
#	serializer/seata-serializer-fst/src/main/java/io/seata/serializer/fst/FstSerializerFactory.java
#	server/pom.xml
#	server/src/main/java/io/seata/server/coordinator/DefaultCoordinator.java
#	server/src/main/java/io/seata/server/session/GlobalSession.java
#	server/src/main/java/io/seata/server/session/SessionHelper.java
#	server/src/main/java/io/seata/server/session/SessionHolder.java
#	server/src/main/java/io/seata/server/storage/SessionConverter.java
#	server/src/main/java/io/seata/server/storage/redis/JedisPooledFactory.java
#	server/src/main/java/io/seata/server/storage/redis/lock/RedisLocker.java
#	server/src/main/resources/application.yml
#	server/src/main/resources/logback-spring.xml
#	server/src/test/java/io/seata/server/LoaderConfTest.java
#	server/src/test/java/io/seata/server/store/db/LogStoreDataBaseDAOTest.java
#	spring-aot/seata-spring-aot-core/pom.xml
#	spring/src/main/java/io/seata/spring/annotation/GlobalTransactionScanner.java
#	sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/EscapeHandler.java
#	sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/KeywordChecker.java
#	sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/util/ColumnUtils.java
#	sqlparser/seata-sqlparser-druid/src/main/java/io/seata/sqlparser/druid/mariadb/MariadbSelectForUpdateRecognizer.java
#	sqlparser/seata-sqlparser-druid/src/main/java/io/seata/sqlparser/druid/polardbx/PolarDBXDeleteRecognizer.java
#	sqlparser/seata-sqlparser-druid/src/main/resources/META-INF/services/io.seata.sqlparser.druid.SQLOperateRecognizerHolder
#	tcc/src/main/java/io/seata/rm/tcc/config/TCCFenceConfig.java
#	tm/src/main/java/io/seata/tm/api/DefaultGlobalTransaction.java
#	tm/src/main/java/io/seata/tm/api/TransactionalTemplate.java
@wangliang181230
Copy link
Contributor Author

@xingfudeshi I changed the base branch to 2.x, PTAL.

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
补充下change log
Please supplement the change log.

@apache apache deleted a comment from slievrly Nov 27, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't add the author info.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 30f88b6 into apache:2.x Nov 29, 2023
@wangliang181230 wangliang181230 deleted the git-commit-id-plugin branch November 29, 2023 07:03
@funky-eyes funky-eyes added this to the 2.1.0 milestone Nov 29, 2023
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.