feat: support strict projection#946
Merged
liurenjie1024 merged 5 commits intoapache:mainfrom Apr 15, 2025
Merged
Conversation
Contributor
Author
Xuanwo
reviewed
Feb 8, 2025
ZENOTME
force-pushed
the
strict_projection
branch
from
b777e3b to
d5b1c36
Compare
kevinjqliu
pushed a commit
to apache/iceberg-python
that referenced
this pull request
Mar 11, 2025
Follow up of apache/iceberg-rust#946. Looking at Java, this should be fine: - String: https://github.com/apache/iceberg/blob/19330fa19f833f481063704c1e0122e068289259/api/src/main/java/org/apache/iceberg/transforms/Truncate.java#L364-L365 - Binary: https://github.com/apache/iceberg/blob/19330fa19f833f481063704c1e0122e068289259/api/src/main/java/org/apache/iceberg/transforms/Truncate.java#L445-L446
liurenjie1024
previously approved these changes
Apr 14, 2025
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @ZENOTME for this great pr, and all the tests! LGTM!
| } | ||
|
|
||
| fn not(&mut self, _inner: Self::T) -> crate::Result<Self::T> { | ||
| unreachable!("InclusiveProjection should not be performed against Predicates that contain a Not operator. Ensure that \"Rewrite Not\" gets applied to the originating Predicate before binding it.") |
Contributor
There was a problem hiding this comment.
Suggested change
| unreachable!("InclusiveProjection should not be performed against Predicates that contain a Not operator. Ensure that \"Rewrite Not\" gets applied to the originating Predicate before binding it.") | |
| unreachable!("StrictProjection should not be performed against Predicates that contain a Not operator. Ensure that \"Rewrite Not\" gets applied to the originating Predicate before binding it.") |
nit: I prefer to throw Unexpected error here.
liurenjie1024
approved these changes
Apr 15, 2025
Contributor
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @ZENOTME for this pr!
Contributor
|
Thanks for working on this @ZENOTME This is great! |
Fokko
added a commit
to apache/iceberg-python
that referenced
this pull request
Apr 25, 2025
Follow up of apache/iceberg-rust#946. Looking at Java, this should be fine: - String: https://github.com/apache/iceberg/blob/19330fa19f833f481063704c1e0122e068289259/api/src/main/java/org/apache/iceberg/transforms/Truncate.java#L364-L365 - Binary: https://github.com/apache/iceberg/blob/19330fa19f833f481063704c1e0122e068289259/api/src/main/java/org/apache/iceberg/transforms/Truncate.java#L445-L446
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
Follow up of apache/iceberg-rust#946. Looking at Java, this should be fine: - String: https://github.com/apache/iceberg/blob/19330fa19f833f481063704c1e0122e068289259/api/src/main/java/org/apache/iceberg/transforms/Truncate.java#L364-L365 - Binary: https://github.com/apache/iceberg/blob/19330fa19f833f481063704c1e0122e068289259/api/src/main/java/org/apache/iceberg/transforms/Truncate.java#L445-L446
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of #735.
The implementation refers pyiceberg. Most of the code is test migrate from: https://github.com/apache/iceberg-python/blob/main/tests/test_transforms.py#L997