Skip to content

build: check in Cargo.lock#851

Merged
Xuanwo merged 2 commits intoapache:mainfrom
xxchan:xxchan/cruel-anaconda
Dec 27, 2024
Merged

build: check in Cargo.lock#851
Xuanwo merged 2 commits intoapache:mainfrom
xxchan:xxchan/cruel-anaconda

Conversation

@xxchan
Copy link
Member

@xxchan xxchan commented Dec 26, 2024

The lockfile is based on latest available dependencies after running cargo update.

Notes:

The lockfile is based on latest available dependencies after running `cargo update`.

Notes:
- It's not considered an antipattern any more https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html And e.g., opendal has it: https://github.com/apache/opendal/blob/main/core/Cargo.lock
- This is needed for rust-cache to work well. Because rust-cache caches all dependencies, keyed by `Cargo.lock`

Signed-off-by: xxchan <[email protected]>
@xxchan xxchan mentioned this pull request Dec 26, 2024
Signed-off-by: xxchan <[email protected]>
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @xxchan for this.

@Xuanwo Xuanwo merged commit 8883b5e into apache:main Dec 27, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants