feat(puffin): Parse Puffin FileMetadata#765
Conversation
fqaiser94
force-pushed
the
puffin_metadata
branch
from
d4703f4 to
b9c4c6f
Compare
| mod compression; | ||
| pub use compression::CompressionCodec; | ||
|
|
||
| mod metadata; |
There was a problem hiding this comment.
Note that I have deliberately chosen to not expose anything at the moment.
I want to create a separate, intentional PR to add pub modifiers after the reader and writer implementations have been added.
This way, we can develop inside this crate without having to worry about breaking changes until we're ready.
If it helps though, I intend to expose the following outside of the crate eventually:
pub use metadata::{BlobMetadata, FileMetadata, CREATED_BY_PROPERTY};
fqaiser94
force-pushed
the
puffin_metadata
branch
4 times, most recently
from
4d3dd9f to
011945e
Compare
|
@fqaiser94, just added the higher level statistic files in #799 FYI. I would guess you would end up building those soon too. |
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you @fqaiser94 for working on this! Here are some minor suggestions.
| } | ||
|
|
||
| #[derive(Clone, PartialEq, Eq, Hash, Debug)] | ||
| pub(crate) enum Flag { |
There was a problem hiding this comment.
Currently the Puffin spec only supports one flag (as documented here) but allows for the possibility that there may be more flags in the future.
fqaiser94
force-pushed
the
puffin_metadata
branch
2 times, most recently
from
c06c3d1 to
aa321ee
Compare
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @fqaiser94 for this great pr! Generally LGTM, left some minor suggestion.
fqaiser94
force-pushed
the
puffin_metadata
branch
2 times, most recently
from
3caf54e to
378c97a
Compare
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
Thanks @fqaiser94 for this great pr, and all the tests! Left some minor suggestions, others look great to me!
fqaiser94
force-pushed
the
puffin_metadata
branch
from
378c97a to
25f5873
Compare
liurenjie1024
left a comment
liurenjie1024
left a comment
There was a problem hiding this comment.
LGTM, thanks @fqaiser94 for this great pr!
|
Let's wait for a moment to see if others need to take a look. |
4 participants
Part of #744
Summary
Add support for parsing Puffin FileMetadata
Context