Repository navigation
feat(rest): use iceberg-rust as the User-Agent product token - #3668
Merged
Merged
Conversation
The REST catalog spec recommends a standard User-Agent format whose library token for Rust is iceberg-rust (apache/iceberg#17727), so send iceberg-rust/<version> instead of iceberg-rs/<version>. A header.user-agent property still overrides the default.
kevinjqliu
approved these changes
Nov 10, 2026
Contributor
|
pretty simple pr so i think we can merge. This change should show up in the next release, 0.12 |
Contributor
who is Issac? 😄 |
Contributor
Author
|
@kevinjqliu Ha, Isaac is the internal name for the Claude I use at work. Our policy adds that line to PR descriptions, and I'm not allowed to edit it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No issue was filed; this follows the REST catalog spec change in apache/iceberg#17727.
What changes are included in this PR?
The REST catalog spec now recommends a standard User-Agent format whose library token for Rust is
iceberg-rust. This changes the default User-Agent fromiceberg-rs/<version>toiceberg-rust/<version>. Aheader.user-agentproperty still overrides it.Are these changes tested?
Yes, the existing header tests in
catalog.rsare updated for the new value.This pull request and its description were written by Isaac.