Repository navigation
feat(delete-vector): make the delete_vector module public - #3461
Merged
Merged
Conversation
An engine that uses the crate for metadata but reads Parquet with a reader of its own cannot go through ArrowReader, and so far had to reimplement the deletion-vector-v1 decoding to apply deletion vectors. Expose the module, the way puffin already is, with the docs deny(missing_docs) then requires, an is_empty next to len, and the public API snapshot regenerated. Co-authored-by: Claude <[email protected]>
CTTY
approved these changes
Oct 14, 2026
CTTY
left a comment
CTTY
left a comment
Collaborator
There was a problem hiding this comment.
LGTM!
Currently the CI is unstable and we are merging fixes. Let's wait for CI fixes to go in first before merging it
This was referenced Oct 15, 2026
dina-kar
added a commit
to ostrium-labs/iceberg-rust
that referenced
this pull request
Oct 21, 2026
delete_vector is a public module since apache#3461, so rustdoc -D warnings rejects the intra-doc link to the private decode_roaring_directory. Signed-off-by: Dinakaran <[email protected]>
22 of 64 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Makes
iceberg::delete_vectora public module, soDeleteVector,DeleteVectorIteratorandDeleteVector::deserializecan be used outside the crate. An engine that uses this crate for metadata but reads Parquet with a reader of its own cannot go throughArrowReader, and without this it has to reimplement thedeletion-vector-v1decoding and validation that #2866 added. This mirrorspuffin, which already exports the container around the vector (PuffinReader,PuffinWriter,DELETION_VECTOR_V1) but not the vector itself.With the module public,
deny(missing_docs)applies to it, so:DeleteVector::is_emptyis added next tolen, for clippy'slen_without_is_empty;#[allow(unused)]onDeleteVector::newis dropped, since it is used.No behaviour changes.
crates/iceberg/public-api.txtis regenerated withmake generate-public-api.Are these changes tested?
No new tests: the change is visibility and documentation. The existing
delete_vectorunit tests pass, as docargo clippy --all-targets --all-features -- -D warnings,cargo docwith warnings denied, and the public API check. The decoder is also exercised from outside the crate by our engine's integration test against deletion vectors written by Spark with Iceberg 1.10.1, which is what motivated this change.AI Disclosure
Developed with Claude Code (Anthropic); the commit carries a
Co-authored-bytrailer for it. I understand and support these changes.