Repository navigation
Conversation
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
|
Don't close it, it's a missing feature. |
9f41c52 to
8149d7d
Compare
| cargo test -p iceberg-storage-common \ | ||
| --test file_io_suite \ | ||
| --test resolving_suite \ | ||
| -- --ignored --test-threads=1 _hf hf_ |
There was a problem hiding this comment.
This feels kinda hacky and makes me think if we should just leave hf io tests alone. curious to hear what others think
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. |
There was a problem hiding this comment.
Is this going to be expanded later?
| } | ||
|
|
||
| async fn load_opendal_s3() -> Option<StorageHarness> { | ||
| let minio_endpoint = get_minio_endpoint(); |
There was a problem hiding this comment.
is minio still supporting these test cases?
| ) | ||
| } | ||
|
|
||
| async fn load_opendal_hf() -> Option<StorageHarness> { |
There was a problem hiding this comment.
Nitpick: can a comment clarify that this is for hugging face and not hadoop or something else.
| pub const ENV_HF_DATASET: &str = "HF_DATASET"; | ||
|
|
||
| #[derive(Debug, Clone, Copy)] | ||
| pub enum StorageKind { |
There was a problem hiding this comment.
Leaving the comment for note taking.
It would be cool to see Azure, Glue, & S3Tables.
|
so this is the stale pr ur talking about? |
|
cc @CTTY |
|
ig ur busy, so am starting to work on this |
Which issue does this PR close?
What changes are included in this PR?
Are these changes tested?
They are tests themselves :D